Skip to content

Separate secret key material from config parameters in LSPS2 and LSPS5 #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
martinsaposnic opened this issue Apr 17, 2025 · 0 comments
Open

Separate secret key material from config parameters in LSPS2 and LSPS5 #3743

martinsaposnic opened this issue Apr 17, 2025 · 0 comments
Labels
lightning-liquidity

Comments

@martinsaposnic
Copy link

As discussed here #3662 (comment)

Currently, secret key material such as signing_key in LSPS5 and promise_secret in LSPS2 is included directly in the Config structs. While this works for now, it's not ideal to mix sensitive cryptographic material with general configuration parameters.

We should consider refactoring the codebase to store secrets separately from the rest of the configuration data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lightning-liquidity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tnull @martinsaposnic