Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: decimal display support pt. 2 #948

Closed
4 tasks done
jharveyb opened this issue Jun 12, 2024 · 3 comments
Closed
4 tasks done

[feature]: decimal display support pt. 2 #948

jharveyb opened this issue Jun 12, 2024 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@jharveyb
Copy link
Contributor

jharveyb commented Jun 12, 2024

Addressing #925 , continuation of #930 .

  • Only encode non-default (non-zero) precision values.
  • Reject mints if the existing JSON metadata is too big to add the precision field to, if precision was specified.
  • On reissuance, fetch the precision from the asset metadata (if possible) of the asset group anchor, and assert equality with the reissuance request.
    -- "Precision should be fixed for all issuances in an asset group"
  • display new precision field on some (?) RPC responses
    -- ListAssets, ListTransfers, and the address-related RPC calls
@jharveyb jharveyb added the enhancement New feature or request label Jun 12, 2024
@dstadulis
Copy link
Collaborator

dstadulis commented Jun 13, 2024

  • Add guidance / explanation in documentation the rationale behind a decimal display / precision of four
    • Specify parity of the smallest unit
  • Add recommended use of decimal display in documentation

@dstadulis dstadulis added this to the v0.4 milestone Jun 14, 2024
@dstadulis dstadulis moved this from 🆕 New to 🏗 In progress in Taproot-Assets Project Board Jun 14, 2024
@dstadulis dstadulis assigned GeorgeTsagk and unassigned jharveyb Jun 18, 2024
@dstadulis dstadulis modified the milestones: v0.4, v0.4.1 Jul 16, 2024
@Roasbeef
Copy link
Member

#1059 will fix the last two bullet points here

@Roasbeef
Copy link
Member

Fixed by #1059

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Taproot-Assets Project Board Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants