Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting room for message assignments #716

Open
t-bast opened this issue Dec 10, 2019 · 5 comments
Open

Waiting room for message assignments #716

t-bast opened this issue Dec 10, 2019 · 5 comments
Labels
Waiting Room Waiting room for id assignment or similar

Comments

@t-bast
Copy link
Collaborator

t-bast commented Dec 10, 2019

Message types (2-bytes id) are only finally assigned when they're included into the spec.
While a new message is being tested, you can announce the temporary id you're going to use here.
This will (hopefully) prevent collision between unassigned ids on the network, while also allowing people to quickly see what experiments are being run on the network.

Id Name Description
TBD your_message description
@t-bast t-bast added the Waiting Room Waiting room for id assignment or similar label Dec 10, 2019
@t-bast
Copy link
Collaborator Author

t-bast commented Jan 21, 2020

These are the custom messages used by Phoenix:

Id Name Description
35001 pay_to_open_request phoenix
35003 pay_to_open_response phoenix
35005 swap_in_pending phoenix
35007 swap_in_request phoenix
35009 swap_in_response phoenix
35011 swap_out_request phoenix
35013 swap_out_response phoenix
35015 swap_in_confirmed phoenix

@sputn1ck
Copy link

sputn1ck commented Dec 1, 2021

At peerswap we rolled the dice and landed on:

Id Name Description
42069 swap_in_request peerswap
42071 swap_out_request peerswap
42073 swap_in_agreement peerswap
42075 fee_response peerswap
42077 tx_opened_response peerswap
42079 canceled peerswap
42081 claimed peerswap
42083 coop_close peerswap
42085 poll peerswap
42087 request_poll peerswap

The spec and project will be open source soon

@ariard
Copy link

ariard commented Jan 26, 2023

@JssDWt
Copy link
Contributor

JssDWt commented Mar 23, 2023

A note for people that want to reserve message numbers for their application:

Consider picking a single even/odd pair for your application and use the fist bytes of the message to identify the message type. Because the space of available numbers is somewhat scarce. This way you only use one or two numbers instead of an entire range.

@ZmnSCPxj-jr
Copy link

ZmnSCPxj-jr commented Mar 25, 2023

BitcoinAndLightningLayerSpecs/lsp#23

Id Name Description
37913 lsps0_message_id Message conforming to LSPS0 specification.

Single message, as per principle in #716 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting Room Waiting room for id assignment or similar
Projects
None yet
Development

No branches or pull requests

5 participants