Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: update lnd to be compatible with btcd master #4255

Closed
Roasbeef opened this issue May 6, 2020 · 1 comment · Fixed by #4291
Closed

rpc: update lnd to be compatible with btcd master #4255

Roasbeef opened this issue May 6, 2020 · 1 comment · Fixed by #4291
Assignees
Labels
btcd compatibility rpc Related to the RPC interface
Milestone

Comments

@Roasbeef
Copy link
Member

Roasbeef commented May 6, 2020

The latest version of btcd master broke an existing API, by taking a value that was a bool and making it an int (or the other way around). Similar to what we've done in the past w.r.t probing to see which versions are supported, we also need to patch in this change. Ideally we can prevent things like this on the btcd end, by just adding the new field if possible under a distinct name. The call in question is GetBlockVerboseTx: btcsuite/btcd#1529

@Roasbeef Roasbeef added this to the 0.10.1 milestone May 6, 2020
@Roasbeef Roasbeef added btcd compatibility rpc Related to the RPC interface labels May 6, 2020
@Roasbeef
Copy link
Member Author

With the dependent PRs in now, we just need to update our go.mod, and then also travis to start building against that new commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
btcd compatibility rpc Related to the RPC interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants