Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect version precedence in the v0.15.1-beta track #6935

Open
burdiyan opened this issue Sep 21, 2022 · 1 comment
Open

Incorrect version precedence in the v0.15.1-beta track #6935

burdiyan opened this issue Sep 21, 2022 · 1 comment
Labels
golang/build system Related to the go language and compiler

Comments

@burdiyan
Copy link

Background

It seems like the versioning scheme you've chosen for v0.15.1-beta track is not compatible with SemVer.

We noticed that because our Renovate bot setup wanted to upgrade our LND dependency from v0.15.1-beta to v0.15.1-beta.rc2 although the former is released as newer than the latter by LND.

I thought the issue was inside Renovate, but a coworker pointed out to the SemVer spec, and Renovate seems to be doing the correct thing. See point 11 in the spec:

Example: 1.0.0-alpha < 1.0.0-alpha.1 < 1.0.0-alpha.beta < 1.0.0-beta < 1.0.0-beta.2 < 1.0.0-beta.11 < 1.0.0-rc.1 < 1.0.0.

So 1.0.0-alpha is lower than 1.0.0-alpha.1 which seems to fit this example with LND version.
@Roasbeef Roasbeef added the golang/build system Related to the go language and compiler label Sep 21, 2022
@Roasbeef
Copy link
Member

Related issue: #6860

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
golang/build system Related to the go language and compiler
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roasbeef @burdiyan