Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag for manually specifying remote delay when opening channels #792

Closed
halseth opened this issue Mar 1, 2018 · 4 comments
Closed

Flag for manually specifying remote delay when opening channels #792

halseth opened this issue Mar 1, 2018 · 4 comments
Labels
beginner Issues suitable for new developers channels cli Related to the command line interface feature request Requests for new features funding Related to the opening of new channels with funding transactions on the blockchain good first issue Issues suitable for first time contributors to LND rpc Related to the RPC interface

Comments

@halseth
Copy link
Contributor

halseth commented Mar 1, 2018

As discussed in #788, the only way to manually set the remote CSV delay for channels is by using the --defaultremotedelay flag at startup, which will be applied to all channels opened from that point on. In certain cases it is needed to manually specify this delay, in order to create channels compatible with less conservative implementations than lnd. In particular, c-lightning tolerates a delay of maximum 3 days, while lnd scales all the way up to 2 weeks for large channels.

While we want the defaults to be as safe as possible, it makes sense to allow the user to specify a shorter delay on a per channel basis, in the case she wants to open a channel with a node not supporting long delays. We should therefore add a flag to openchannel that let's the user specify this, the default still being scaling linearly with channel size.

After such a flag is added, I think the --defaultremotedelay startup option can be made applicable only to incoming channels, as you can emulate it for outgoing channels with the new flag to openchannel (if this simplifies the code in anyway).

@halseth halseth added rpc Related to the RPC interface funding Related to the opening of new channels with funding transactions on the blockchain channels feature request Requests for new features good first issue Issues suitable for first time contributors to LND cli Related to the command line interface labels Mar 1, 2018
@halseth
Copy link
Contributor Author

halseth commented Mar 7, 2018

Related: #800

@Roasbeef Roasbeef added the beginner Issues suitable for new developers label Mar 9, 2018
@Roasbeef Roasbeef added this to the v0.4-beta milestone Mar 14, 2018
@Roasbeef Roasbeef removed this from the v0.4-beta milestone Mar 15, 2018
@vctt94
Copy link
Contributor

vctt94 commented Mar 24, 2018

Can I give this issue a try?

@halseth
Copy link
Contributor Author

halseth commented Mar 24, 2018

@vctt94 Hi, this is already fixed by #840, but I would suggest trying to tackle (parts of) #800, it is very similar :)

@vctt94
Copy link
Contributor

vctt94 commented Mar 24, 2018

Hey @halseth , thanks for letting me know and suggesting me #800 , I will look into it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Issues suitable for new developers channels cli Related to the command line interface feature request Requests for new features funding Related to the opening of new channels with funding transactions on the blockchain good first issue Issues suitable for first time contributors to LND rpc Related to the RPC interface
Projects
None yet
Development

No branches or pull requests

3 participants