Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mandatory origin argument in Script.compile #6

Open
francisbouvier opened this issue Oct 11, 2023 · 0 comments
Open

Mandatory origin argument in Script.compile #6

francisbouvier opened this issue Oct 11, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@francisbouvier
Copy link
Member

v8::Script::Compile requires an origin argument, which is a pointer to a v8.ScriptOrigin.

The actual implementation in Zig Script.compile allow to pass null which will cause the following v8 crash:

#
# Fatal error in v8::ScriptCompiler::Compile
# v8::ScriptCompiler::CompileModule must be used to compile modules
#

We should instead make this parameter non-optional.
@francisbouvier francisbouvier added the bug Something isn't working label Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@francisbouvier