-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for SEP0029 #272
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add support for SEP 29. This is important to provide a simple way to protect users from forgetting memos when submitting payments to exchanges.
What would you like to see?
Add
server.checkMemoRequired(tx)
with support for SEP0029.If any of the operations included in
tx
are of typepayment
,pathPaymentStrictReceive
,pathPaymentStrictSend
, ormergeAccount
, then the SDK will load the destination account from Horizon and check ifconfig.memo_required
is set to1
as defined in SEP0029.Change
server.SubmitTransaction
to always check if memo is required.Allow the the check to be bypassed by setting
skipMemoRequiredCheck
totrue
, but default to requiring the check:The check should be skipped automatically if the transaction includes a memo.
You can use the following implementations as a reference:
JS SDK
: Add SEP0029 memo required check. stellar/js-stellar-sdk#516Go SDK
: clients/horizonclient: Add SEP0029 memo required check. stellar/go#2396Refs: stellar/stellar-protocol#575
The text was updated successfully, but these errors were encountered: