Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the data type of certain fields to store the expected design values. #499

Closed
overcat opened this issue Aug 3, 2023 · 1 comment
Assignees

Comments

@overcat
Copy link
Member

overcat commented Aug 3, 2023

What version are you using?

latest code.

What did you do?

Check #494 first.

Currently, some fields are using data types that are insufficient to hold the expected design values. As an example, memo.id = 18446744073709551615, and in this SDK, memo id is stored using Long. If this SDK is used to parse this transaction, the correct result cannot be obtained. We should modify it to be stored using BigInteger.

The following fields should be corrected.

field before after
LedgerBounds.minLedger int long
LedgerBounds.maxLedger int long
MemoId.id long BigInteger
TimeBounds.minTime long BigInteger
TimeBounds.maxTime long BigInteger
TransactionBuilder.baseFee int long
TransactionPreconditions.TIMEOUT_INFINITE long BigInteger
TransactionPreconditions.minSeqAge Long BigInteger
TransactionPreconditions.minSeqLedgerGap int long

What did you expect to see?

These field types have been corrected.

What did you see instead?

N/A

@overcat
Copy link
Member Author

overcat commented Aug 23, 2023

Implemented in #498.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants