Merge pull request #750 from tisnik/lcore-740-type-hints-for-models-unit-tests

LCORE-740: type hints for models unit tests

Author: tisnik

tests/unit/models/config/test_conversation_cache.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 
 import pytest
+from pytest_subtests import SubTests
 
 from pydantic import ValidationError
 
@@ -30,7 +31,7 @@ def test_conversation_cache_unknown_type() -> None:
         _ = ConversationCacheConfiguration(type="foo")
 
 
-def test_conversation_cache_correct_type_but_not_configured(subtests) -> None:
+def test_conversation_cache_correct_type_but_not_configured(subtests: SubTests) -> None:
     """Check the test for cache type."""
     with subtests.test(msg="Memory cache"):
         with pytest.raises(
@@ -51,7 +52,7 @@ def test_conversation_cache_correct_type_but_not_configured(subtests) -> None:
             _ = ConversationCacheConfiguration(type=constants.CACHE_TYPE_POSTGRES)
 
 
-def test_conversation_cache_no_type_but_configured(subtests) -> None:
+def test_conversation_cache_no_type_but_configured(subtests: SubTests) -> None:
     """Check the test for cache type."""
     m = "Conversation cache type must be set when backend configuration is provided"
 
@@ -79,7 +80,7 @@ def test_conversation_cache_no_type_but_configured(subtests) -> None:
             _ = ConversationCacheConfiguration(postgres=d)
 
 
-def test_conversation_cache_multiple_configurations(subtests) -> None:
+def test_conversation_cache_multiple_configurations(subtests: SubTests) -> None:
     """Test how multiple configurations are handled."""
     d = PostgreSQLDatabaseConfiguration(
         db="db",

tests/unit/models/config/test_customization.py

@@ -1,13 +1,14 @@
 """Unit tests for Customization model."""
 
 import pytest
+from pytest_subtests import SubTests
 
 from pydantic import ValidationError
 
 from models.config import Customization
 
 
-def test_service_customization(subtests) -> None:
+def test_service_customization(subtests: SubTests) -> None:
     """Check the service customization class."""
     with subtests.test(msg="System prompt is enabled"):
         c = Customization()
@@ -43,7 +44,7 @@ def test_service_customization_wrong_system_prompt_path() -> None:
         _ = Customization(system_prompt_path="/path/does/not/exists")
 
 
-def test_service_customization_correct_system_prompt_path(subtests) -> None:
+def test_service_customization_correct_system_prompt_path(subtests: SubTests) -> None:
     """Check the service customization class."""
     with subtests.test(msg="One line system prompt"):
         # pass a file containing system prompt

tests/unit/models/config/test_database_configuration.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 
 import pytest
+from pytest_subtests import SubTests
 
 from pydantic import ValidationError
 
@@ -13,7 +14,7 @@
 )
 
 
-def test_database_configuration(subtests) -> None:
+def test_database_configuration(subtests: SubTests) -> None:
     """Test the database configuration handling."""
     with subtests.test(msg="PostgreSQL"):
         d1 = PostgreSQLDatabaseConfiguration(

tests/unit/models/config/test_dump_configuration.py

@@ -23,7 +23,7 @@
 )
 
 
-def test_dump_configuration(tmp_path) -> None:
+def test_dump_configuration(tmp_path: Path) -> None:
     """
     Test that the Configuration object can be serialized to a JSON file and
     that the resulting file contains all expected sections and values.
@@ -186,7 +186,7 @@ def test_dump_configuration(tmp_path) -> None:
         }
 
 
-def test_dump_configuration_with_one_mcp_server(tmp_path) -> None:
+def test_dump_configuration_with_one_mcp_server(tmp_path: Path) -> None:
     """
     Verify that a configuration with a single MCP server can be
     serialized to JSON and that all expected fields and values are
@@ -234,7 +234,7 @@ def test_dump_configuration_with_one_mcp_server(tmp_path) -> None:
         ]
 
 
-def test_dump_configuration_with_more_mcp_servers(tmp_path) -> None:
+def test_dump_configuration_with_more_mcp_servers(tmp_path: Path) -> None:
     """
     Test that a configuration with multiple MCP servers can be
     serialized to JSON and that all server entries are correctly
@@ -301,7 +301,7 @@ def test_dump_configuration_with_more_mcp_servers(tmp_path) -> None:
         ]
 
 
-def test_dump_configuration_with_quota_limiters(tmp_path) -> None:
+def test_dump_configuration_with_quota_limiters(tmp_path: Path) -> None:
     """
     Test that the Configuration object can be serialized to a JSON file and
     that the resulting file contains all expected sections and values.

tests/unit/models/config/test_postgresql_database_configuration.py

@@ -3,6 +3,7 @@
 from pathlib import Path
 
 import pytest
+from pytest_subtests import SubTests
 
 from pydantic import ValidationError
 
@@ -29,7 +30,7 @@ def test_postgresql_database_configuration() -> None:
     assert c.ca_cert_path is None
 
 
-def test_postgresql_database_configuration_port_setting(subtests) -> None:
+def test_postgresql_database_configuration_port_setting(subtests: SubTests) -> None:
     """Test the PostgreSQLDatabaseConfiguration model."""
     with subtests.test(msg="Correct port value"):
         c = PostgreSQLDatabaseConfiguration(
@@ -51,7 +52,7 @@ def test_postgresql_database_configuration_port_setting(subtests) -> None:
             )
 
 
-def test_postgresql_database_configuration_ca_cert_path(subtests) -> None:
+def test_postgresql_database_configuration_ca_cert_path(subtests: SubTests) -> None:
     """Test the PostgreSQLDatabaseConfiguration model."""
     with subtests.test(msg="Path exists"):
         c = PostgreSQLDatabaseConfiguration(

tests/unit/models/requests/test_query_request.py

@@ -102,7 +102,7 @@ def test_get_documents(self) -> None:
 
     def test_get_documents_no_attachments(self) -> None:
         """Test the get_documents method."""
-        attachments = []
+        attachments: list[Attachment] = []
         qr = QueryRequest(
             query="Tell me about Kubernetes",
             attachments=attachments,