Merge pull request #362 from tisnik/inference-configuration-is-not-optional

Inference configuration is not optional

Author: tisnik

docs/config.png

@@ -12,7 +12,7 @@ class "AuthenticationConfiguration" as src.models.config.AuthenticationConfigura
 class "Configuration" as src.models.config.Configuration {
   authentication : Optional[AuthenticationConfiguration]
   customization : Optional[Customization]
-  inference : Optional[InferenceConfiguration]
+  inference
   llama_stack
   mcp_servers : list[ModelContextProtocolServer]
   name : str
@@ -86,6 +86,7 @@ class "UserDataCollection" as src.models.config.UserDataCollection {
   check_storage_location_is_set_when_needed() -> Self
 }
 src.models.config.DataCollectorConfiguration --* src.models.config.UserDataCollection : data_collector
+src.models.config.InferenceConfiguration --* src.models.config.Configuration : inference
 src.models.config.JwtConfiguration --* src.models.config.JwkConfiguration : jwt_configuration
 src.models.config.LlamaStackConfiguration --* src.models.config.Configuration : llama_stack
 src.models.config.ServiceConfiguration --* src.models.config.Configuration : service

docs/config.puml

@@ -106,7 +106,7 @@ def customization(self) -> Optional[Customization]:
         return self._configuration.customization
 
     @property
-    def inference(self) -> Optional[InferenceConfiguration]:
+    def inference(self) -> InferenceConfiguration:
         """Return inference configuration."""
         assert (
             self._configuration is not None

src/configuration.py

@@ -249,7 +249,7 @@ class Configuration(BaseModel):
         AuthenticationConfiguration()
     )
     customization: Optional[Customization] = None
-    inference: Optional[InferenceConfiguration] = InferenceConfiguration()
+    inference: InferenceConfiguration = InferenceConfiguration()
 
     def dump(self, filename: str = "configuration.json") -> None:
         """Dump actual configuration into JSON file."""

src/models/config.py

@@ -577,7 +577,7 @@ def test_dump_configuration_with_one_mcp_server(tmp_path) -> None:
         ),
         mcp_servers=mcp_servers,
         customization=None,
-        inference=None,
+        inference=InferenceConfiguration(),
     )
     dump_file = tmp_path / "test.json"
     cfg.dump(dump_file)
@@ -628,7 +628,7 @@ def test_dump_configuration_with_more_mcp_servers(tmp_path) -> None:
         ),
         mcp_servers=mcp_servers,
         customization=None,
-        inference=None,
+        inference=InferenceConfiguration(),
     )
     dump_file = tmp_path / "test.json"
     cfg.dump(dump_file)