Skip to content

Commit fb6833a

Browse files
authored
Merge pull request #269 from onmete/fix-uv
OLS-1946: Fix contributing.md for uv
2 parents 1316ad8 + a1f3f58 commit fb6833a

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,15 +56,15 @@ git clone https://github.com/YOUR-GIT-PROFILE/lightspeed-stack.git
5656
cd lightspeed-stack
5757

5858
# setup your devel environment with uv
59-
uv install -G dev
59+
uv sync --group dev
6060

61-
# Now you can run test commands trough make targets, or prefix the rest of commands with `uv run`, eg. `uv run make test`
61+
# Now you can run test commands trough make targets, or prefix the rest of commands with `uv run`, eg. `uv run make test` or do `uv venv`, which creates virtual environment and prints activation command, and run commands inside venv.
6262

6363
# run unit tests
64-
make unit-tests
64+
make test-unit
6565

6666
# run integration tests
67-
make integration-tests
67+
make test-integration
6868

6969
# code formatting
7070
# (this is also run automatically as part of pre-commit hook if configured)

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ run-data-collector: ## Run the data collector service locally
1414
test-unit: ## Run the unit tests
1515
@echo "Running unit tests..."
1616
@echo "Reports will be written to ${ARTIFACT_DIR}"
17-
COVERAGE_FILE="${ARTIFACT_DIR}/.coverage.unit" uv run pytest tests/unit --cov=src --cov-report term-missing --cov-report "json:${ARTIFACT_DIR}/coverage_unit.json" --junit-xml="${ARTIFACT_DIR}/junit_unit.xml" --cov-fail-under=60
17+
COVERAGE_FILE="${ARTIFACT_DIR}/.coverage.unit" uv run python -m pytest tests/unit --cov=src --cov-report term-missing --cov-report "json:${ARTIFACT_DIR}/coverage_unit.json" --junit-xml="${ARTIFACT_DIR}/junit_unit.xml" --cov-fail-under=60
1818

1919
test-integration: ## Run integration tests tests
2020
@echo "Running integration tests..."
2121
@echo "Reports will be written to ${ARTIFACT_DIR}"
22-
COVERAGE_FILE="${ARTIFACT_DIR}/.coverage.integration" uv run pytest tests/integration --cov=src --cov-report term-missing --cov-report "json:${ARTIFACT_DIR}/coverage_integration.json" --junit-xml="${ARTIFACT_DIR}/junit_integration.xml" --cov-fail-under=10
22+
COVERAGE_FILE="${ARTIFACT_DIR}/.coverage.integration" uv run python -m pytest tests/integration --cov=src --cov-report term-missing --cov-report "json:${ARTIFACT_DIR}/coverage_integration.json" --junit-xml="${ARTIFACT_DIR}/junit_integration.xml" --cov-fail-under=10
2323

2424
test-e2e: ## Run BDD tests for the service
2525
PYTHONDONTWRITEBYTECODE=1 uv run behave --tags=-skip -D dump_errors=true @tests/e2e/test_list.txt \

0 commit comments

Comments
 (0)