Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple JS SDK from hardcoded Sirius Relayer constants #8

Open
EnchanterIO opened this issue Sep 17, 2019 · 0 comments
Open

Decouple JS SDK from hardcoded Sirius Relayer constants #8

EnchanterIO opened this issue Sep 17, 2019 · 0 comments
Assignees
@EnchanterIO
Labels
enhancement New feature or request
Milestone
FanBase

Comments

@EnchanterIO
Copy link
Contributor

EnchanterIO commented Sep 17, 2019 •
edited
Loading

Due to shortage of time I hardcoded 2 hacks to OpenZeppelin node modules:

  • const relay_lookup_limit_blocks = 1000;
  • a RelayerURL "gsn.sirius.lightstreams.io" path in openzeppelin/gsn-provider node module dependency

File containing both hacks: node_modules/@openzeppelin/gsn-provider/src/tabookey-gasless/RelayClient.js

I added comments and will fix this in the incoming weeks but this will do for the moment.

These changes will be automatically applied by a post-install script using a patching strategy.
@EnchanterIO EnchanterIO added the enhancement New feature or request label Sep 17, 2019
@EnchanterIO EnchanterIO added this to the FanBase milestone Sep 17, 2019
@EnchanterIO EnchanterIO self-assigned this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EnchanterIO EnchanterIO

Labels
enhancement New feature or request
Projects
None yet
Milestone
FanBase
Development

No branches or pull requests
1 participant
@EnchanterIO