Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor naming and workflow of filtered images generation #1413

Open
dbu opened this issue Nov 2, 2021 · 0 comments
Open

refactor naming and workflow of filtered images generation #1413

dbu opened this issue Nov 2, 2021 · 0 comments
Milestone

Comments

@dbu
Copy link
Member

dbu commented Nov 2, 2021

i am tempted to cleanup some of the process and also naming how the filtered image files are created. especially with webp support, things are a bit muddy to me.

"resolve cache" is used to populate the cache. that is a strange name. we should streamline naming.

we have several classes that are not super obvious, with FilterPathContainer and FilterService.

WarmupCacheHandler calls FilterService::warmupCache but then also FilterService::getUrlOfFilteredImage (because of #1347). the only thing i see that the additional call does is triggering resolve events. i think it would be better to have warmupCache also trigger those events. ResolveCacheCommand does only call warmupCache, so it won't trigger the events if i understand correctly.

@dbu dbu added this to the 3.0.0 milestone Nov 4, 2021
@dbu dbu changed the title refactor workflow of filtered images generation refactor naming and workflow of filtered images generation May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant