Refactor controller business logic to service(s) #806
Labels
Attn: BC Break
This issue or PR results in a backwards-compatibility break and therefore requires a major release.
Attn: Blocker
This item blocks other issue(s) or PR(s) and therefore must be resolved prior.
Level: New Feature 🆕
This item involves the introduction of new functionality.
State: Confirmed
This item has been confirmed by maintainers as legitimate.
Comments
robfrawley
added
Attn: Blocker
|
Current work on this feature is being contributed by @jehaby in the sandbox repository clone. A formal PR will originate from there once an implementation is finalized, for inclusion in this repo's |
robfrawley
added
Attn: BC Break
|
@jehaby Just moved this to the "in peer review" stage on the project tracker. I will be taking a look over the next few days to provide feedback on your initial stab at implementing this feature! |
|
the controller seems cleaned up now, i think this has been done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the
1.xcodebase, the controller defines a large subset of routing and conditional logic between the different objects required to successfully generate and cache a transformed image, and as the current controller interface requires a request object, such must be mocked when called outside a context where a request object is natively available.This is inconvenient, and can be improved.
This
2.xfeature is to tear the vast majority of business logic out from the controller and define a collection of (or one?) services that implement the required logic to "glue" together the different layers needed. Most importantly, this new functionality should be request-agnostic.The text was updated successfully, but these errors were encountered: