Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure valid format #93

Closed
rdohms opened this issue Jul 31, 2012 · 3 comments
Closed

Ensure valid format #93

rdohms opened this issue Jul 31, 2012 · 3 comments
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. Level: New Feature 🆕 This item involves the introduction of new functionality.
Milestone

Comments

@rdohms
Copy link

rdohms commented Jul 31, 2012

Currently when outputting a profile that has no specified format, the bundle uses the file's extension, however it does not check if that extension ins actually a valid format, which causes breaks in the backend and broken images.

The bundle should validate the extension against known and compatible image output formats, and fall back to a specific format if it finda nothing valid. (FilterManager)

@makasim
Copy link
Collaborator

makasim commented Mar 14, 2014

I think it was fixed in #291

@makasim makasim closed this as completed Mar 14, 2014
@rdohms
Copy link
Author

rdohms commented Mar 14, 2014

@makasim maybe write a testcase that can verify this?

@makasim
Copy link
Collaborator

makasim commented Mar 14, 2014

we use mimetype\format guesser that comes with symfony. as far as I know it uses file content to guess a mimetype. I think guesser logic is covered in symfony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Level: Bug 🐞 This item involves a legitimate regression (bug) to existing functionality. Level: New Feature 🆕 This item involves the introduction of new functionality.
Projects
None yet
Development

No branches or pull requests

2 participants