Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using ngDialog.close() doesn't work as expected with Angular 1.4.0 #243

Closed
julienpa opened this issue Jun 3, 2015 · 1 comment
Closed
Assignees
Labels

Comments

@julienpa
Copy link

julienpa commented Jun 3, 2015

ngDialog.close() without arguments is supposed to do the same as ngDialog.closeAll(), but since I updated to Angular 1.4, it broke all my calls to close() (not closing opened dialogs).

Maybe this will be fixed when a compatible version will be released? (the dependencies seem to indicate that ngDialog 0.4.0 requires Angular 1.3.15).

@egor-smirnov
Copy link
Member

Will look at this in the nearest days and let you know how it goes. Seems to be quite important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants