Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closeByEscape closes dialogs it shouldn't #86

Closed
joelstein opened this issue Sep 24, 2014 · 5 comments · Fixed by #226
Closed

closeByEscape closes dialogs it shouldn't #86

joelstein opened this issue Sep 24, 2014 · 5 comments · Fixed by #226
Labels

Comments

@joelstein
Copy link

I think I found a bug. If I open a dialog with closeByEscape: false, and then open a second dialog without this option (thus defaulting to true), typing the "escape" key will close both modals. The expected behavior is that the first modal wouldn't be closeable via the escape key.

See it in action here:
http://jsfiddle.net/joelstein/rsdeufgz/

@joelstein
Copy link
Author

Actually, it doesn't matter how the first dialog is configured. I think my expected behavior is that typing the "escape" key would only close the top dialogs, but it closes all of them.

@voronianski voronianski added the bug label Oct 7, 2014
@pelizza
Copy link

pelizza commented Dec 28, 2014

+1

1 similar comment
@tgelu
Copy link

tgelu commented Feb 17, 2015

+1

@saadlu
Copy link

saadlu commented Apr 16, 2015

+1

I think my expected behavior is that typing the "escape" key would only close the top dialogs, but it closes all of them.

Exactly my expectation and that's why I am here.

@bchelli
Copy link
Contributor

bchelli commented Apr 30, 2015

💯
This is good news this is bugging me in my app
Thanks @jemise111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants