Delegate the task of sending event attendance notification emails to StandaloneEventAttendanceRepository #1421
+1,288
−451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It was challenging to use Scala from a Java context especially when dealing with Refined types.
HoussemNasri
force-pushed
the
event-attenandce-notification-email
branch
from
3ced5f5 to
0adf9d3
Compare
chibenwa
reviewed
Dec 19, 2024
...c/main/scala/com/linagora/tmail/james/common/LinagoraCalendarEventAcceptMethodContract.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Dec 19, 2024
...ensions/src/main/java/com/linagora/tmail/james/jmap/StandaloneEventAttendanceRepository.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Dec 19, 2024
...ensions/src/main/java/com/linagora/tmail/james/jmap/StandaloneEventAttendanceRepository.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Dec 20, 2024
HoussemNasri
changed the title
chibenwa
approved these changes
Dec 20, 2024
HoussemNasri
commented
Dec 24, 2024
Comment on lines
+1060
to
+1061
| @Test | ||
| def shouldFailWhenBlobIdIsNotPrefixedByMessageId(): Unit = { |
There was a problem hiding this comment.
Note: This test is only appropriate for StandaloneEventAttendanceRepository, as it is the only implementation currently available. Once a CarDav repository is implemented, this test should be moved to a standalone-specific location.
HoussemNasri
commented
Dec 24, 2024
| MailboxSession systemMailboxSession = sessionProvider.createSystemSession(username); | ||
|
|
||
| return Flux.from(messageIdManager.getMessagesReactive(List.of(messageId), FetchGroup.MINIMAL, systemMailboxSession)) | ||
| .map(MessageResult::getMailboxId) | ||
| return getEnclosingMessageId(eventBlobIds).flatMap(messageId -> |
There was a problem hiding this comment.
The assumption here that input Blobs will belong to the same email message is wrong, as nothing in the JMAP API explicitly says that; thus, the PR needs a bit more work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1400