Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove <TAB> flick? #99

Open
widogg opened this issue Apr 8, 2024 · 3 comments
Open

Can we remove <TAB> flick? #99

widogg opened this issue Apr 8, 2024 · 3 comments

Comments

@widogg
Copy link

widogg commented Apr 8, 2024

hi!

In my local git copy, I have commented these lines, because I don't really like to have a message when I .

However, this doesn't prevent the console to flick for an instant (or more, if the complete takes longer) when I press .

Whould it be possible to remove this behaviour? Until the last couple of days, I've been using fzf-obc and it doesn't has this behavior. Instead, FZF starts one line below current promtp (and I actually prefer this kind of behavior)

@lincheney
Copy link
Owner

Hi
The flicker is unavoidable, it is a side effect of how bash/readline works with keybindings.
I tried fzf-obc and found that it also had flicker, however it had less flicker than this repo. I will take a look to see what it is doing and see if I can apply here.

@widogg
Copy link
Author

widogg commented Apr 9, 2024

The thing that I've noticed is that fzf-obc starts one line below

(ignore the different theme)
image

In this example, using autocomplete on /usr, fzf-tab has a noticeable flickr while fzf-obc doesn't. And I think is caused by "replacing" the prompt with fzf output, while obc decides to put it one line below.

While I don't have a preference on the "style" on where to put fzf (same line vs line below), it's the constant flickr that bothers me

@lincheney
Copy link
Owner

I had a look at this, I think the reason fzf-obc doesn't flicker as much is that it is overriding the individual completion functions rather than the completion itself. Bash must be doing something where if you are invoking normal completion it doesn't hide the prompt or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants