Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical scrolling not working #23

Open
emigr2k1 opened this issue Sep 26, 2018 · 6 comments
Open

Vertical scrolling not working #23

emigr2k1 opened this issue Sep 26, 2018 · 6 comments

Comments

@emigr2k1
Copy link
Contributor

Using MacOS Mojave, ITerm and default MacOS terminal.

If I write lines until they fill the viewport I cannot see the new lines. Kod still receives my input because if I delete the first lines I can see what I wrote.

Video

I can work on it. I just need a clue about why it doesn't work on mac because I see that it works on linux (I suppose, by looking at the screenshot in README.md)

@linde12
Copy link
Owner

linde12 commented Sep 26, 2018

Hey, great! I just noticed this myself as well and i'm guessing that xi has changed the protocol a bit since it was implemented in kod. That's the reason why it works in the screenshot.

Would be awesome if you wanted to take a peek at it @emigr2k1 ! 😄

@emigr2k1
Copy link
Contributor Author

Checking the log, it looks like Kod is not handling the method "scroll_to" which was an op of "update" before.
I'll send a PR tomorrow if I can :)

@linde12
Copy link
Owner

linde12 commented Sep 26, 2018

Awesome!

@sixtyfive
Copy link

Have you guys ever gotten this to work again? I'm still experiencing it...

@linde12
Copy link
Owner

linde12 commented Sep 27, 2018

@sixtyfive Not yet, but @emigr2k1 has figured out the root cause. It worked in the past but xi-editor is under development and API changes from time to time so kod doesn't handle it correctly with the latest version of xi-core.

@emigr2k1
Copy link
Contributor Author

emigr2k1 commented Oct 1, 2018

How should the scroll be handled?
Do you have any idea on how to do this?
Should we simulate scrolling just replacing the lines in the viewport or render all the lines and actually scroll the viewport (I don't know if that'a possible)?
I have an almost working version of scrolling just rendering the lines in the viewport but I'm having problems when there's an update of invalidBefore in linecache, I could do a hack to fix it but it would look dirty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants