You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Currently when Multi-Gitter is called with the close command, the GitLab implementation actually deletes the Merge Request instead of closing it. This results in the Merge Request not being able to be found anymore. Furthermore, this requires admin or owner level privileges, which is not necessarily required for Multi-Gitter to work.
Expected behavior
Instead of deleting, the Merge Request should be closed
Additional context
The function that should close the Merge Request actually calls the DeleteMergeRequest, which calls the DELETE method on the api
Describe the bug
Currently when Multi-Gitter is called with the
close
command, the GitLab implementation actually deletes the Merge Request instead of closing it. This results in the Merge Request not being able to be found anymore. Furthermore, this requiresadmin
orowner
level privileges, which is not necessarily required for Multi-Gitter to work.Expected behavior
Instead of deleting, the Merge Request should be closed
Additional context
The function that should close the Merge Request actually calls the DeleteMergeRequest, which calls the DELETE method on the api
multi-gitter/internal/scm/gitlab/gitlab.go
Line 393 in bb08990
Instead the Merge Request should be updated with the
state_event: close
The text was updated successfully, but these errors were encountered: