Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to configure repository clone directory (currently system temp) #294

Closed
Sam13 opened this issue Oct 21, 2022 · 4 comments · Fixed by #366
Closed

Add ability to configure repository clone directory (currently system temp) #294

Sam13 opened this issue Oct 21, 2022 · 4 comments · Fixed by #366
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Sam13
Copy link

Sam13 commented Oct 21, 2022

I'm running multi-gitter inside a Docker / VS Code devcontainer environment.
It would be nice to configure the directory where multi-gitter clones the repositories.
Currently this is the system temporary directory:

multi-gitter/internal/multigitter/run.go

Line 202 in c12fb13

tmpDir, err := os.MkdirTemp(os.TempDir(), "multi-git-changer-")

This would allow mounting a Docker volume and examine the GIT changes in interactive mode with a GIT GUI of choice on the Docker host.
Currently I have to map the system temporary directory to the Docker host which is not nice.
@Sam13 Sam13 added the bug Something isn't working label Oct 21, 2022
@lindell lindell added enhancement New feature or request and removed bug Something isn't working labels Oct 21, 2022
@lindell
Copy link
Owner

lindell commented Oct 21, 2022

I would merge a PR if this where added :) --tmp-dir might be a good option name?

@Sam13
Copy link
Author

Sam13 commented Oct 21, 2022

Sorry, I have no Go knowledge :-|

Maybe --clone-directory fits better?

@lindell
Copy link
Owner

lindell commented Oct 21, 2022

Maybe --clone-directory fits better?

Agree.

I'm happy to provide constructive feedback on the PR, no matter if the initial iterations will be non-idiomatic, etc.

@lindell lindell added the good first issue Good for newcomers label Oct 23, 2022
@filipkrayem filipkrayem mentioned this issue Jul 3, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 4, 2024

Included in release v0.52.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ability to configure repository clone directory filipkrayem/multi-gitter
2 participants
@lindell @Sam13