-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter repositories using topics #320
Conversation
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This is definitely something useful that should be added. However, there are two questions that needs to be answered first.
- Are topics supported on other platforms? Should be an easy implementation in that case, and I'm happy to test it out if needed.
- Multiple topics to be filtered are supported in the current implementation, which should be the case. But I'm unsure if it should be that all topics specified must exist, or if any of the topics has to exist. (The latter is implemented). Any input here? :)
I did not check yet as I don' use any other platform atm. But might have a look if I find the time.
I asked myself the same question. I came to the conclusion that it makes more sense to match if any exists. Although this might be a matter of taste. But it should not get complicated for a user to configure it so I went with the later. Might just be a matter of documentation. |
Taking a quick look, it seems that topic exist in: ✔️ GitHub If you are unfamiliar with GitLab and GitLab, I could add it in this PR. |
I will have a look 👍🏻 |
Signed-off-by: Raffael Sahli <raffael.sahli@doodle.com>
Added support for gitlab and gita. Although I doubt topics is a widely used feature in gitea since I didn't even see the option in the ui to set topics. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great with the added SCMS! Looks good, but there are some minor changes to be made.
Co-authored-by: Johan Lindell <johan@lindell.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just a test in tests/story_test.go
and it should be ready to merge 😄
Thanks for the contribution 😄 Are you ready to have it merged? |
If we agree how the topics are filtered then yeah lets 🚢 |
Included in release v0.44.0 🎉 |
What does this change
feat: filter github repositories using topics
What issue does it fix
We have hundreds of repositories and targeting them all or providing a list of repositories is annoying to do so.
It would be nicer just to target repos filtered by topic name.
For example I'd like to add a fix targeting all repos labeled backend.
Checklist