feat(github): Update existing draft PR to Ready For Review #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an existing PR exists and the `--draft` flag is not present in the run command, update the existing PR from "Draft" to "Ready For Review" Closes lindell#455.
lindell
approved these changes
May 23, 2024
|
Included in release v0.52.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
When an existing PR exists and the
--draftflag is not present in the run command, update the existing PR from "Draft" to "Ready For Review"What issue does it fix
Closes #455.
Notes for the reviewer
I noticed this issue, and figured I would want to use it in some upcoming work I want to do. And I figured this is the one line change that you mentioned in #455 (comment). I saw that this already exists for the Gitea and GitLab implementations. Let me know if there are any tests or anything else specific you'd like to see and I can try to figure that out.
Checklist