Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure: com.linecorp.armeria.xds.client.endpoint.DynamicHealthCheckTest.gracefulEndpointUpdate() #5897

Open
minwoox opened this issue Sep 10, 2024 · 1 comment

Comments

@minwoox
Copy link
Member

minwoox commented Sep 10, 2024

org.opentest4j.AssertionFailedError: 
expected: /127.0.0.1:34782
 but was: /127.0.0.1:34794
	at app//com.linecorp.armeria.xds.client.endpoint.DynamicHealthCheckTest.gracefulEndpointUpdate(DynamicHealthCheckTest.java:272)
	at java.base@11.0.22/java.lang.reflect.Method.invoke(Method.java:566)
	at java.base@11.0.22/java.util.ArrayList.forEach(ArrayList.java:1541)
	at java.base@11.0.22/java.util.ArrayList.forEach(ArrayList.java:1541)

@jrhee17
Copy link
Contributor

jrhee17 commented Sep 10, 2024

Looking at the logs, it seems like the connection was reset for some reason:

07:51:22.179 [armeria-common-worker-epoll-3-4] WARN  c.l.a.i.c.AbstractHttp2ConnectionHandler - [id: 0xfa43be94, L:/127.0.0.1:34782 - R:127.0.0.1/127.0.0.1:43087] HTTP/2 connection error:
io.netty.handler.codec.http2.Http2Exception: failed to consume a HEADERS frame
	at io.netty.handler.codec.http2.Http2Exception.connectionError(Http2Exception.java:121)
	at com.linecorp.armeria.client.Http2ResponseDecoder.onHeadersRead(Http2ResponseDecoder.java:220)

To be honest, I don't think there's much that can be done for this case other than marking as flaky, or removing it.

Given that this test isn't really failing often compared to other tests, let me just monitor this case and remove if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants