Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A failed H2C upgrade causes an invocation failure when server sends 'Connection: close' header. #86

Closed
trustin opened this issue Jan 18, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@trustin
Copy link
Member

trustin commented Jan 18, 2016

When an Armeria client sends the HEAD / upgrade request, some HTTP/1 servers send a 404 response with a Connection: close header instead of keeping the connection alive. The Armeria client attempts to send an HTTP/1 request for the current invocation to the closed connection after receiving the rejected upgrade response, which is incorrect and thus raises a SessionClosedException.

To fix this issue, we could make Armeria client handle Connection: close header properly and remember the list of the hosts that rejected the upgrade request.

(Originally reported by @anuraaga)

@trustin trustin added the defect label Jan 18, 2016
@trustin trustin added this to the 0.8.0.Final milestone Jan 18, 2016
@trustin trustin modified the milestones: 0.8.0.Final, 0.9.0.Final Jan 25, 2016
@trustin trustin self-assigned this Feb 7, 2016
@trustin
Copy link
Member Author

trustin commented Feb 7, 2016

Should be fixed by #107

@trustin trustin modified the milestone: 0.9.0.Final Feb 23, 2016
@trustin
Copy link
Member Author

trustin commented Mar 7, 2016

Fixed in 0.9.0.Final

@trustin trustin closed this as completed Mar 7, 2016
@trustin trustin added this to the 0.9.0.Final milestone Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant