feat: apply the ibc module of lbm-sdk #1
Conversation
dudong2
requested review from
0Tech,
jaeseung-bae,
loin3,
tkxkd0159 and
zemyblue
I meant the tendermint proto file in the |
|
|
||
| module github.com/cosmos/ibc-go/v3 |
There was a problem hiding this comment.
Is it no problem to remove /v3 path?
There was a problem hiding this comment.
It's just a specifier indicating the path and version for that module. Also, for line/ibc-go, I thought that v3 had no meaning, so I removed it.
There was a problem hiding this comment.
I think it has some reason, because each version of cosmos/ibc-go has each module path.
https://github.com/cosmos/ibc-go/blob/8f0cfb0682bb6dc6cf311d4644b300041e277866/go.mod#L3
docs/versions
Outdated
| release/v2.0.x v2.0.0 | ||
| release/v1.2.x v1.2.0 | ||
| release/v1.1.x v1.1.0 | ||
| main main |
There was a problem hiding this comment.
This file is the latest patch versions for the currently maintained minor versions. The line/ibc-go will continue to follow a specific version of ibc-go, so i decided that the doc specifying the version of cosmos/ibc-go is not necessary. If it is thought that there is a need to manage multiple minor versions of line/ibc-go in the future, it would be a good idea to add it then.
There was a problem hiding this comment.
I think it is necessary if we wan to communicate with other cosmos chain.
Because all the parts corresponding to ibc/light-client/tendermint have been changed to ostracon, adding tendermint seems to change a lot. After bump up to v3.3.1, i will proceed with adding tendermint. |
| What problems may be addressed by introducing this feature? | ||
| What benefits does the ibc-go stand to gain by including this feature? | ||
| What benefits does the SDK stand to gain by including this feature? |
There was a problem hiding this comment.
It would be better to revert the change.
| What benefits does the SDK stand to gain by including this feature? | |
| What benefits does the ibc-go stand to gain by including this feature? |
| var cache sdk.MultiStorePersistentCache | ||
| var cccc sdk.MultiStorePersistentCache // TODO(dudong2): change cccc -> ?? |
Description
Apply all the ibc modules changes of lbm-sdk.
The x/ibc module is copied from the 0fbc2fcae6dba90fa80b815cf3219d6fcf46fc64 commit hash in lbm-sdk.
closes: #859
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml