Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify key type name #145

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

egonspace
Copy link

@egonspace egonspace commented Apr 23, 2021

Description

modified key name to ostracon/PrivXXX, ostracon/PubkeyXXX

also

  • removed keys-migrate command and related test
  • removed keys legacy(keyring-backend db)

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Apr 23, 2021
@egonspace egonspace added this to the Initail ebony milestone Apr 23, 2021
@egonspace egonspace merged commit ff6eab4 into v2/develop Apr 26, 2021
@egonspace egonspace deleted the egon/v2/fix/modify_key_type branch May 27, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants