-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: memoize bech32 encoding and decoding #216
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2/develop #216 +/- ##
==============================================
- Coverage 53.49% 53.46% -0.04%
==============================================
Files 653 652 -1
Lines 47376 47379 +3
==============================================
- Hits 25343 25330 -13
- Misses 19178 19187 +9
- Partials 2855 2862 +7
|
egonspace
reviewed
Jun 1, 2021
egonspace
reviewed
Jun 1, 2021
egonspace
approved these changes
Jun 1, 2021
Looks very good! |
egonspace
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bech32
encoding and decoding takes a lot of time, so memoize itIt is appropriate to add a layer to choose whether to access the cache or to run actual conversion.
There are too many parts that call
AccAddressFromBech32
orAccAddress.String
(baseapp, most modules, Json marshaling, etc.)I am concerned that there will be many changes, so it would be better to proceed later.
Profile
AS-IS
TO-BE
Because of the performance improvement of
types.AccAddress.String
andtypes.AccAddressFromBech32
,DeliverTx
is faster-->
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes