Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix branch name in ci script #234

Merged
merged 2 commits into from
Jun 9, 2021
Merged

chore: fix branch name in ci script #234

merged 2 commits into from
Jun 9, 2021

Conversation

egonspace
Copy link

@egonspace egonspace commented Jun 9, 2021 •
edited
Loading

Description

  • modify branch name from github action script
  • remove circleci script

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Jun 9, 2021
@egonspace egonspace added the github_actions Pull requests that update Github_actions code label Jun 9, 2021
@egonspace egonspace added this to the prepare open sour milestone Jun 9, 2021
@egonspace egonspace requested review from wetcod and iproudhon June 9, 2021 07:29
wetcod
wetcod approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 3ccf391 into develop Jun 9, 2021
@egonspace egonspace deleted the egon/chore/fix_branch_name branch June 9, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetcod wetcod wetcod approved these changes

@iproudhon iproudhon Awaiting requested review from iproudhon

Assignees

@egonspace egonspace

Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Milestone
prepare open source
Development

Successfully merging this pull request may close these issues.
2 participants
@egonspace @wetcod