-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Merge wasmd 0.19.0 #444
Conversation
* Store contract response in event * Review feedback
* Add cli alias * Review feedback
* Charge gas for custom event attributes * Introduce gas register for gas costs * Review feedback * Tests and minor updates * Godoc
(cherry-pick: tests are not done before upgrading wasmvm v0.16.x)
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
==========================================
+ Coverage 55.54% 55.73% +0.18%
==========================================
Files 716 719 +3
Lines 73837 73921 +84
==========================================
+ Hits 41012 41198 +186
+ Misses 29714 29611 -103
- Partials 3111 3112 +1
|
@@ -115,7 +117,7 @@ func TestSDKMessageHandlerDispatch(t *testing.T) { | |||
}{ | |||
"all good": { | |||
srcRoute: sdk.NewRoute(types.RouterKey, capturingRouteFn), | |||
srcEncoder: func(sender sdk.AccAddress, msg json.RawMessage, customEncodeRouter types.Router) ([]sdk.Msg, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember CustomEncoder was added for Token/collection module encoding.
When the Token/Collection module porting is complete, we need to re-enable it.
Is there a reason to delete the custom encoder again in this migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct. But this patch contains various changes around these functions, so I chose to delete it temporarily and re-enable it after porting the Token/Collection module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. In my opinion, It's kind of a rollback, so I want it to remain as is as possible.
However since the time remaining until release is too tight, please make it a other issue. and please don't miss out write the changelog.
docs/proto/proto-docs.md
Outdated
@@ -0,0 +1,1116 @@ | |||
<!-- This file is auto-generated. Please do not modify it yourself. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be a duplicate of the following, is that necessary?
docs/core/proto-docs.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice found
store-instantiate still has
|
…ate command's help
Thanks. It is in only help message and does not work now. I removed them from help messages. |
In general, LGTM. please add to the Unreleased section in the changelog. |
Description
Merging CosmWasm/wasmd/x/wasm 's version 0.19.0
Motivation and context
We will upgrade cosmwasm and wasmvm to version 0.16.x. And, this upgrade needs to use them.
How has this been tested?
Unit tests in x/wasm.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml