Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a feature of whitelist for /lbm.foundation.v1.MsgWithdrawFromTreasury #528

Merged
merged 132 commits into from
May 20, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented May 5, 2022

Description

closes: #527

Motivation and context

Refer to #527.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech requested review from dudong2 and zemyblue May 13, 2022 06:01
proto/lbm/foundation/v1/authz.proto Outdated Show resolved Hide resolved
proto/lbm/foundation/v1/authz.proto Outdated Show resolved Hide resolved
proto/lbm/foundation/v1/authz.proto Outdated Show resolved Hide resolved
proto/lbm/foundation/v1/event.proto Show resolved Hide resolved
x/foundation/keeper/genesis.go Outdated Show resolved Hide resolved
}.WithAuthorization(&foundation.ReceiveFromTreasuryAuthorization{}),
},
},
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about adding the worst case about authorizations?

x/foundation/authz.go Show resolved Hide resolved
x/foundation/keeper/keys.go Show resolved Hide resolved
x/foundation/keeper/keys.go Show resolved Hide resolved
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please more increase the coverage as possible as. specially proposal.go and grant.go, authz.go. Thank you.

x/foundation/client/cli/tx.go Show resolved Hide resolved
x/foundation/foundation.go Show resolved Hide resolved
x/foundation/msgs.go Outdated Show resolved Hide resolved
x/foundation/keeper/msg_server.go Show resolved Hide resolved
x/foundation/keeper/grpc_query.go Outdated Show resolved Hide resolved
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit 7c3db3b into Finschia:main May 20, 2022
@0Tech 0Tech deleted the foundation branch May 24, 2022 02:50
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: improvement Changes in existing functionality C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a feature of whitelist for /lbm.foundation.v1.MsgWithdrawFromTreasury
3 participants