Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change gRPC path to original cosmos path #564

Merged
merged 11 commits into from
Jun 17, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Jun 15, 2022

Description

related: #549

Rollback the gRPS path of origin cosmos-sdk

  • proto/lbm/auth/v1 -> proto/cosmos/auth/v1beta1
  • proto/lbm/authz/v1 -> proto/cosmos/authz/v1beta1
  • proto/lbm/bank/v1 -> proto/cosmos/bank/v1beta1
  • proto/lbm/base -> proto/cosmos/base
    • not ostracon
  • proto/lbm/capability -> proto/cosmos/capability/v1beta1
  • proto/lbm/crisis/v1 -> proto/cosmos/crisis/v1beta1
  • proto/lbm/crypto -> proto/cosmos/crypto
  • proto/lbm/distribution/v1 -> proto/cosmos/distribution/v1beta1
  • proto/lbm/evidence/v1 -> proto/cosmos/evidence/v1beta1
  • proto/lbm/feegrant/v1 -> proto/cosmos/feetrant/v1beta1
  • proto/lbm/genutil/v1 -> proto/cosmos/genutil/v1beta1
  • proto/lbm/gov/v1 -> proto/cosmos/gov/v1beta1
  • proto/lbm/mint/v1 -> proto/cosmos/mint/v1beta1
  • proto/lbm/params/v1 -> proto/cosmos/params/v1beta1
  • proto/lbm/slashing/v1 -> proto/cosmos/slashing/v1beta1
  • proto/lbm/staking/v1 -> proto/cosmos/staking/v1beta1
  • proto/lbm/tx/signing/v1 -> proto/cosmos/tx/signing/v1beta1
  • proto/lbm/tx/v1 -> proto/cosmos/tx/v1beta1
  • proto/lbm/upgrade/v1 -> proto/cosmos/upgrade/v1beta1
  • proto/lbm/vesting/v1 -> proto/cosmos/vesting/v1beta1

ETC changes

Motivation and context

lbm-sdk can't use cosmos-sdk base open source because the function is same but the gRPC path is difference. So I think we need to rollback the path to original path.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

zemyblue added 2 commits June 15, 2022 22:02
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>

# Conflicts:
#	go.sum
@zemyblue zemyblue self-assigned this Jun 15, 2022
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #564 (b473df7) into main (6157f09) will decrease coverage by 0.00%.
The diff coverage is 63.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   57.59%   57.58%   -0.01%     
==========================================
  Files         793      793              
  Lines       86584    86589       +5     
==========================================
- Hits        49866    49865       -1     
- Misses      33558    33563       +5     
- Partials     3160     3161       +1     
Impacted Files Coverage Δ
client/grpc/tmservice/query.pb.go 29.07% <ø> (ø)
codec/types/interface_registry.go 53.96% <ø> (ø)
types/codec.go 60.00% <ø> (ø)
x/auth/legacy/v043/store.go 58.29% <ø> (ø)
x/evidence/types/codec.go 47.05% <0.00%> (ø)
x/gov/types/codec.go 38.46% <0.00%> (ø)
x/staking/client/rest/query.go 45.79% <ø> (ø)
types/abci.pb.go 0.51% <54.54%> (+0.03%) ⬆️
types/coin.pb.go 6.17% <55.55%> (ø)
store/types/commit_info.pb.go 0.97% <57.14%> (ø)
... and 18 more

@zemyblue zemyblue marked this pull request as draft June 15, 2022 13:52
zemyblue added 5 commits June 15, 2022 23:00
… gRPC define.

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue marked this pull request as ready for review June 16, 2022 04:30
@zemyblue zemyblue requested review from dudong2 and 0Tech June 16, 2022 04:30
Signed-off-by: zemyblue <zemyblue@gmail.com>
baseapp/block_gas_test.go Show resolved Hide resolved
client/query_test.go Outdated Show resolved Hide resolved
client/query_test.go Outdated Show resolved Hide resolved
Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link
Contributor

@dudong2 dudong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

zemyblue added 2 commits June 16, 2022 21:08
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue merged commit c1a1267 into Finschia:main Jun 17, 2022
@zemyblue zemyblue deleted the rename_grpc_path branch June 17, 2022 00:51
@zemyblue zemyblue mentioned this pull request Jul 6, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants