feat: update x/ibc to support github.com/cosmos/ibc-go@v3.0.0 #651

ulbqb · 2022-08-26T06:06:45Z

Description

This PR enable to support github.com/cosmos/ibc-go@v3.0.0.

The directory structure between x/ibc and ibc-go is different. The directories correspond as follows.

x/ibc	ibc-go
x/ibc/applications	modules/apps
x/ibc/core	modules/core
x/ibc/light-clients	modules/light-clients
x/ibc/testing	testing

This PR contains the following changes:

Update x/ibc to github.com/cosmos/ibc-go@v3.0.0
Fix x/wasm to support updated x/ibc
Merge github.com/cosmos/ibc-go/testing/simapp and github.com/CosmWasm/wasmd/app into github.com/line/lbm-sdk/simapp

This PR contains the following lbm-sdk specific changes:

Merge github.com/cosmos/ibc-go/testing/simapp and github.com/CosmWasm/wasmd/app into github.com/line/lbm-sdk/simapp
Change this test to support x/bankplus/keeper.SendCoinsFromModuleToAccount that does not have blacklist check (commit: acb3a9d)
Change github.com/cosmos/ibc-go to support ostracon (commit: c57f8e3)
Fix swagger-combine config to merge github.com/cosmos/ibc-go/proto into lbm-sdk/proto (commit: ce9e58b)
Not use the inter-tx module in simapp and there are the following notes regarding inter-tx.
https://github.com/CosmWasm/wasmd/blob/v0.27.0/app/app.go#L96-L100

// Note: please do your research before using this in production app, this is a demo and not an officially
// supported IBC team implementation. It has no known issues, but do your own research before using it.
intertx "github.com/cosmos/interchain-accounts/x/inter-tx"
intertxkeeper "github.com/cosmos/interchain-accounts/x/inter-tx/keeper"
intertxtypes "github.com/cosmos/interchain-accounts/x/inter-tx/types"

closes: #585

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

I followed the contributing guidelines and code of conduct.
I have added a relevant changelog to CHANGELOG.md
I have added tests to cover my changes.
I have updated the documentation accordingly.
I have updated API documentation client/docs/swagger-ui/swagger.yaml

zemyblue

Please add swagger apis like https://github.com/cosmos/ibc-go/blob/46e020640e66f9043c14c53a4d215a5b457d6703/docs/client/config.json#L8-L41.

ulbqb · 2022-09-14T02:17:11Z

Please add swagger apis like https://github.com/cosmos/ibc-go/blob/46e020640e66f9043c14c53a4d215a5b457d6703/docs/client/config.json#L8-L41.

@zemyblue It already exists in the current main branch.
https://github.com/line/lbm-sdk/blob/e19f863a8762a6b85c31e8f5c9f4ffb7acbc1a4f/client/docs/config.json#L111-L149

zemyblue

Please check https://github.com/line/lbm-sdk/pull/651/files#diff-44578a53fec2e61d283949550afd5632581e30744b7dc6810fbd4e103b375d67R42.

simapp/app.go

zemyblue · 2022-09-14T07:56:50Z

x/ibc/core/genesis_test.go

 }

 func TestIBCTestSuite(t *testing.T) {
 	suite.Run(t, new(IBCTestSuite))
 }

 func (suite *IBCTestSuite) TestValidateGenesis() {
-	header := suite.chainA.CreateOCClientHeader(suite.chainA.ChainID, suite.chainA.CurrentHeader.Height, clienttypes.NewHeight(0, uint64(suite.chainA.CurrentHeader.Height-1)), suite.chainA.CurrentHeader.Time, suite.chainA.Vals, suite.chainA.Vals, suite.chainA.Voters, suite.chainA.Voters, suite.chainA.Signers)
+	header := suite.chainA.CreateTMClientHeader(suite.chainA.ChainID, suite.chainA.CurrentHeader.Height, clienttypes.NewHeight(0, uint64(suite.chainA.CurrentHeader.Height-1)), suite.chainA.CurrentHeader.Time, suite.chainA.Vals, suite.chainA.Vals, suite.chainA.Voters, suite.chainA.Voters, suite.chainA.Signers)


This logic can communicate with other cosmos-sdk ibc modules?

Are you asking if the name was changed on purpose? This fix was unintentional. I fixed it.
This logic is not related with cosmos-sdk.

No, I just wanted to know this x/ibc module can communicate with other cosmos-sdk base chains. Is it?

It might be a big task, so I'll tackle it as a separate issue. I created the issue as #676.

x/wasm/ibc.go

x/wasm/keeper/relay.go

tnasu · 2022-09-15T07:12:43Z

@tnasu
I wondered if I should change the variable name and type name from tendermint to ostracon. I thought it would be better not to change to ostracon, because when comparing with the original, there will be a mix of non-important differences and important logic differences. What do you think?

I agree with your concerns/meanings. But I know that lbm-sdk uses Ostracon/ostracon/oc in the codes by us:

https://github.com/line/lbm-sdk/pull/317/files

Okay, then, let's separates into other PR.

tnasu · 2022-09-15T07:14:27Z

@tnasu

Could you leave about this in the description? https://github.com/CosmWasm/wasmd/blob/main/app/app.go#L96-L100

	// Note: please do your research before using this in production app, this is a demo and not an officially
	// supported IBC team implementation. It has no known issues, but do your own research before using it.
	intertx "github.com/cosmos/interchain-accounts/x/inter-tx"
	intertxkeeper "github.com/cosmos/interchain-accounts/x/inter-tx/keeper"
	intertxtypes "github.com/cosmos/interchain-accounts/x/inter-tx/types"

Currently this PR does not contain inter-tx module.

I mean that I'd like to update the PR description about inter-tx module.

ulbqb · 2022-09-15T10:02:07Z

I agree with your concerns/meanings. But I know that lbm-sdk uses Ostracon/ostracon/oc in the codes by us:

https://github.com/line/lbm-sdk/pull/317/files

Okay, then, let's separates into other PR.

@tnasu
I created the issue #674.

ulbqb · 2022-09-15T14:39:59Z

Please check https://github.com/line/lbm-sdk/pull/651/files#diff-44578a53fec2e61d283949550afd5632581e30744b7dc6810fbd4e103b375d67R42.

@zemyblue
That link does not work. Maybe, it points to these.
https://github.com/line/lbm-sdk/blob/5dbd91d4b37f0dd933c9bb4f901887611f3c34f3/x/wasm/keeper/relay_test.go#L37
https://github.com/line/lbm-sdk/blob/5dbd91d4b37f0dd933c9bb4f901887611f3c34f3/x/wasm/keeper/relay_test.go#L42

There is no problem as it is, but the FIXME can be eliminate by setting the correct storage gas value. So, I fixed it in 38f772f.

dudong2

LGTM

ulbqb added 8 commits August 26, 2022 12:02

Copy cosmos/ibc-go/v3

bbbb755

Rename tendermint file and directory

33ce099

Replace with correct path

2332ec7

Formatting

366c5b2

Copy cosmos/ibc-go/v3 proto files

85fc34c

Rename tendermint file and directory for proto files

fcc02bf

Replace with correct path for proto files

792a22a

Remove confio/proofs.proto

99556eb

ulbqb marked this pull request as draft August 26, 2022 06:16

ulbqb force-pushed the feature/ibc_v3 branch from 4fe4ce7 to ed374d7 Compare August 26, 2022 06:47

ulbqb added 5 commits August 26, 2022 17:21

Fix swagger-combine config

ce9e58b

Generate swagger files

ffe62d7

Generate stub files

9cea1a3

Fix cosmos/ibc-go/v3 bugs

813696f

Fix go.mod and go.sum

db96083

ulbqb force-pushed the feature/ibc_v3 branch from ed374d7 to 08e25e7 Compare August 26, 2022 08:25

LBM-SDK FEATURES PATHC

c57f8e3

ulbqb force-pushed the feature/ibc_v3 branch from 08e25e7 to c57f8e3 Compare August 26, 2022 08:26

ulbqb requested review from zemyblue, Kynea0b and tnasu August 26, 2022 08:31

ulbqb self-assigned this Aug 26, 2022

ulbqb requested review from 0Tech and dudong2 August 26, 2022 08:34

ulbqb changed the title ~~feat: update lbm-sdk/x/ibc to support cosmos/ibc-go/v3~~ feat: update x/ibc to support github.com/cosmos/ibc-go/v3 Aug 29, 2022

ulbqb changed the title ~~feat: update x/ibc to support github.com/cosmos/ibc-go/v3~~ feat: update x/ibc to support github.com/cosmos/ibc-go@v3.0.0 Aug 29, 2022

ulbqb requested a review from shiki-tak August 29, 2022 08:28

ulbqb added 3 commits September 6, 2022 13:40

ibc v3 support for x/wasm

1d8782e

Remove panic

3a03431

Use github.com/line/lbm-sdk/simapp

52d8039

ulbqb added 4 commits September 12, 2022 14:32

Replace wasmd with simapp

dd1c96c

Replace tendermint with ostracon

16d9ae3

Replace tm with oc

7d5e1cc

Merge branch 'main' into feature/ibc_v3

ab4535d

ulbqb requested review from tnasu, shiki-tak and zemyblue September 12, 2022 05:59

zemyblue reviewed Sep 14, 2022

View reviewed changes

ulbqb requested a review from zemyblue September 14, 2022 02:48

zemyblue reviewed Sep 14, 2022

View reviewed changes

ulbqb added 2 commits September 15, 2022 11:38

Replace TM with OC

66687fc

Use k.newQueryHandler

12fecbd

Fix to correct storage gas

38f772f

dudong2 approved these changes Sep 16, 2022

View reviewed changes

ulbqb requested a review from zemyblue September 16, 2022 04:59

zemyblue approved these changes Sep 18, 2022

View reviewed changes

ulbqb merged commit 80ba750 into Finschia:main Sep 19, 2022

0Tech mentioned this pull request Oct 27, 2022

feat: bump github.com/line/lbm-sdk from e19f863a8 to a389b6330 Finschia/finschia#108

Merged

3 tasks

zemyblue mentioned this pull request Oct 27, 2022

docs: release 0.46.0-rc9 #765

Merged

5 tasks

This was referenced Nov 1, 2022

fix: remove mock from genesis #774

Closed

A mock field is created when simd init #770

Closed

zemyblue mentioned this pull request Nov 28, 2022

Release lbm-sdk v0.46.0 #812

Merged

5 tasks

ulbqb deleted the feature/ibc_v3 branch July 13, 2023 06:55

ulbqb mentioned this pull request Jul 13, 2023

refactor: change the proof.proto path to third_party/proto/confio #1037

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update x/ibc to support github.com/cosmos/ibc-go@v3.0.0 #651

feat: update x/ibc to support github.com/cosmos/ibc-go@v3.0.0 #651

ulbqb commented Aug 26, 2022 •

edited

Loading

zemyblue left a comment

ulbqb commented Sep 14, 2022

zemyblue left a comment

zemyblue Sep 14, 2022

ulbqb Sep 15, 2022 •

edited

Loading

zemyblue Sep 15, 2022

ulbqb Sep 16, 2022

tnasu commented Sep 15, 2022

tnasu commented Sep 15, 2022

ulbqb commented Sep 15, 2022 •

edited

Loading

ulbqb commented Sep 15, 2022 •

edited

Loading

dudong2 left a comment

feat: update x/ibc to support github.com/cosmos/ibc-go@v3.0.0 #651

feat: update x/ibc to support github.com/cosmos/ibc-go@v3.0.0 #651

Conversation

ulbqb commented Aug 26, 2022 • edited Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

zemyblue left a comment

Choose a reason for hiding this comment

ulbqb commented Sep 14, 2022

zemyblue left a comment

Choose a reason for hiding this comment

zemyblue Sep 14, 2022

Choose a reason for hiding this comment

ulbqb Sep 15, 2022 • edited Loading

Choose a reason for hiding this comment

zemyblue Sep 15, 2022

Choose a reason for hiding this comment

ulbqb Sep 16, 2022

Choose a reason for hiding this comment

tnasu commented Sep 15, 2022

tnasu commented Sep 15, 2022

ulbqb commented Sep 15, 2022 • edited Loading

ulbqb commented Sep 15, 2022 • edited Loading

dudong2 left a comment

Choose a reason for hiding this comment

ulbqb commented Aug 26, 2022 •

edited

Loading

ulbqb Sep 15, 2022 •

edited

Loading

ulbqb commented Sep 15, 2022 •

edited

Loading

ulbqb commented Sep 15, 2022 •

edited

Loading