Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable to use libsodium version ostracon #793

Merged
merged 8 commits into from
Nov 14, 2022

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Nov 10, 2022

Description

This PR enable to use libsodium version ostracon. We can use libsodium version ostracon by the following command.

$ LBM_BUILD_OPTIONS=libsodium make install      

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@ulbqb ulbqb changed the title feat: enable to build ostracon using libsodium feat: enable to use ostracon with libsodium Nov 10, 2022
@ulbqb ulbqb self-assigned this Nov 11, 2022
@ulbqb ulbqb marked this pull request as ready for review November 11, 2022 05:23
@ulbqb ulbqb requested review from zemyblue, tnasu and torao November 11, 2022 05:24
@ulbqb ulbqb changed the title feat: enable to use ostracon with libsodium feat: enable to use libsodium version ostracon Nov 11, 2022
@tnasu
Copy link
Member

tnasu commented Nov 11, 2022

Would you add the test with libsodium on github actions?

@ulbqb
Copy link
Member Author

ulbqb commented Nov 11, 2022

Would you add the test with libsodium on github actions?

@tnasu OK, I'll add test. However, adding tests does not guarantee that ostracon is using libsodium. There seem to be no way to tell if ostracon is using libsodium.

@tnasu
Copy link
Member

tnasu commented Nov 11, 2022

@ulbqb Yes, it does. ostracon doesn't tell us whether to use libsodium and what kind of tm-db-backend it uses. It's not convenient. (Thanks for your creating a issue: Finschia/ostracon#486)

But, lbm-sdk is tested with goleveldb, so I recommend adding the test with goleveldb and libsodium.

Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change need to be applied in lbm-sdk v0.46.0-rcx. So could you change the target branch to rc9/v0.46.0?

@ulbqb ulbqb changed the base branch from main to rc9/v0.46.0 November 14, 2022 02:07
@ulbqb ulbqb force-pushed the feat/oc_with_libsodium branch from 3140b19 to 2868333 Compare November 14, 2022 03:25
@ulbqb
Copy link
Member Author

ulbqb commented Nov 14, 2022

@zemyblue
OK. But changing the target branch broke this PR, so I force-pushed.

@ulbqb ulbqb requested a review from zemyblue November 14, 2022 04:34
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulbqb ulbqb merged commit bb6d8fa into Finschia:rc9/v0.46.0 Nov 14, 2022
@ulbqb ulbqb deleted the feat/oc_with_libsodium branch November 14, 2022 07:33
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants