-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable to use libsodium version ostracon #793
Conversation
Would you add the test with libsodium on |
@tnasu OK, I'll add test. However, adding tests does not guarantee that ostracon is using libsodium. There seem to be no way to tell if ostracon is using libsodium. |
@ulbqb Yes, it does. But, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change need to be applied in lbm-sdk v0.46.0-rcx. So could you change the target branch to rc9/v0.46.0
?
3140b19
to
2868333
Compare
@zemyblue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR enable to use libsodium version ostracon. We can use libsodium version ostracon by the following command.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml