fix: Update the http status code handling on upnp #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnasu
added
the
C: enhancement
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
=======================================
Coverage 65.44% 65.44%
=======================================
Files 278 278
Lines 37936 37936
=======================================
Hits 24828 24828
+ Misses 11305 11303 -2
- Partials 1803 1805 +2
|
Mdaiki0730
reviewed
Nov 14, 2022
torao
approved these changes
Nov 14, 2022
Merged
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For more strict handling, I modify checking the response code whether
http.StatusOKor not since UPnP doesn't design the other status code like 30x.