Remove references to layout rect

Author: PoignardAzur

masonry/src/core/contexts.rs

@@ -594,12 +594,8 @@ impl LayoutCtx<'_> {
         self.get_child_state(child).baseline_offset
     }
 
-    /// Get the given child's layout rect.
-    ///
-    /// ## Panics
-    ///
-    /// This method will panic if [`LayoutCtx::run_layout`] and [`LayoutCtx::place_child`]
-    /// have not been called yet for the child.
+    // TODO - Remove (used in Flex)
+    #[doc(hidden)]
     #[track_caller]
     pub fn child_layout_rect(&self, child: &WidgetPod<impl Widget + ?Sized>) -> Rect {
         self.assert_layout_done(child, "child_layout_rect");
@@ -629,7 +625,7 @@ impl LayoutCtx<'_> {
     #[track_caller]
     pub fn child_size(&self, child: &WidgetPod<impl Widget + ?Sized>) -> Size {
         self.assert_layout_done(child, "child_size");
-        self.get_child_state(child).layout_rect().size()
+        self.get_child_state(child).size
     }
 
     /// Skips running the layout pass and calling [`LayoutCtx::place_child`] on the child.
@@ -730,16 +726,6 @@ impl_context_method!(
             self.widget_state.size
         }
 
-        /// The layout rect of the widget in window coordinates.
-        ///
-        /// This is the layout [size](Self::size) and [window_origin](Self::window_origin) combined.
-        ///
-        /// See [layout rect documentation](crate::doc::doc_06_masonry_concepts#layout-rect)
-        /// for details.
-        pub fn global_layout_rect(&self) -> Rect {
-            Rect::from_origin_size(self.widget_state.window_origin(), self.widget_state.size)
-        }
-
         // TODO - Remove
         #[allow(dead_code, reason = "Only used in tests")]
         pub(crate) fn local_layout_rect(&self) -> Rect {

masonry/src/core/widget_state.rs

@@ -294,6 +294,8 @@ impl WidgetState {
     ///
     /// By default, returns the same as [`Self::bounding_rect`].
     pub(crate) fn get_ime_area(&self) -> Rect {
+        // Note: this returns sensible values for a widget that is translated and/or rescaled.
+        // Other transformations like rotation may produce weird IME areas.
         self.window_transform
             .transform_rect_bbox(self.ime_area.unwrap_or_else(|| self.size.to_rect()))
     }

masonry/src/doc/06_masonry_concepts.md

@@ -100,24 +100,24 @@ A widget is considered "interactive" if it can still get text and/or pointer eve
 Stashed and disabled widget are non-interactive.
 
 
-## Layout rect
+## Bounding rect
 
-A widget's layout rect includes its self-declared size, and the position attributed by its parent (local position) / parents (global position).
+A widget's bounding rect is a window-space axis-aligned rectangle inside of which pointer events might affect either the widget or its descendants.
 
-Pointer events cannot target a widget if they are outside its layout rect, though they can target its children (see **Bounding rect** section).
+In general, the bounding rect is a union or a widget's layout rect and the bounding rects of all its descendants.
 
-A layout rect doesn't necessarily have a formal definition; it's generally where the widget will be drawn, though a widget can be drawn outside its layout rect; it's usually a widget's own space and containers will try to avoid having its children's layout rects overlap.
+The bounding rects of the widget tree form a kind of "bounding volume hierarchy": when looking to find which widget a pointer is on, Masonry will automatically exclude any widget if the pointer is outside its bounding rect.
 
+<!-- TODO - Include illustration. -->
 
-## Bounding rect
+<!-- TODO - Add section about clip paths and pointer detection. -->
 
-A widget's bounding rect is a rectangle inside of which pointer events might affect either the widget or its descendants.
 
-In general, the bounding rect is a union or a widget's layout rect and the bounding rects of all its descendants.
+## Layout rect
 
-The bounding rects of the widget tree form a kind of "bounding volume hierarchy": when looking to find which widget a pointer is on, Masonry will automatically exclude any widget if the pointer is outside its bounding rect.
+Previous versions of Masonry had a concept of a widget's "layout rect", composed of its self-declared size and the position attributed by its parent.
 
-<!-- TODO - Include illustration. -->
+However, given that widgets can have arbitrary transforms, the concept of an axis-aligned layout rect doesn't really make sense anymore.
 
 
 ## Safety rails

masonry/src/testing/harness.rs

@@ -472,7 +472,8 @@ impl TestHarness {
     #[track_caller]
     pub fn mouse_move_to(&mut self, id: WidgetId) {
         let widget = self.get_widget(id);
-        let widget_center = widget.ctx().global_layout_rect().center();
+        let local_widget_center = (widget.ctx().size() / 2.0).to_vec2().to_point();
+        let widget_center = widget.ctx().widget_state.window_transform * local_widget_center;
 
         if !widget.ctx().accepts_pointer_interaction() {
             panic!("Widget {id} doesn't accept pointer events");