Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented 0.8.0 no-unlocalized-strings starting point does not seem to match output from 0.7.0 #88

Closed
jgarplind opened this issue Nov 26, 2024 · 1 comment

Comments

@jgarplind
Copy link

jgarplind commented Nov 26, 2024

Under some circumstances, the config specified here: https://github.com/lingui/eslint-plugin/blob/00bfc7cc5a14db44d8bdf87c17f109ad03a11c69/docs/rules/no-unlocalized-strings.md leads to lint failures where 0.7.0 defaults lead to success.

I think that the 0.7.0 version mostly did a better job. Here are some examples:

  1. const url = `${path}${queryParameters}`, obviously there is nothing to translate here
  2. userId: `${user.id}`, arguably should just be refactored to user.id, but still there is nothing to translate here
  3. <h3>Some actual text</h3>, an improvement, since 0.7.0 missed this
  4. `${i18n.date(start, { timeStyle: "short" })}${binding}${i18n.date(end, { timeStyle: "short" })}`, a bit more complex, but still, nothing to translate here

Do you have suggestions on how to achieve expected ignores for 1/2/4?

@timofei-iatsenko
Copy link
Collaborator

It's known issue i prepared a fix for that here #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants