Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack + vite): fix dependency watching in loader #1662

Merged
merged 2 commits into from
May 17, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

Fixing a bug introduced in #1654
Closes: #1661

Vite's addWatchFile does not have a file existance check as webpack has, so i have to add check it manually before.

Also, we need an e2e tests for /example projects. Because this kind of things really hard to test from build side.

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 0:15am

@github-actions
Copy link

github-actions bot commented May 17, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.43 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: +0.08 🎉

Comparison is base (f3824e6) 75.48% compared to head (c63b567) 75.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1662      +/-   ##
==========================================
+ Coverage   75.48%   75.56%   +0.08%     
==========================================
  Files          79       79              
  Lines        2011     2018       +7     
  Branches      518      519       +1     
==========================================
+ Hits         1518     1525       +7     
  Misses        379      379              
  Partials      114      114              
Impacted Files Coverage Δ
packages/vite-plugin/src/index.ts 0.00% <0.00%> (ø)
...es/cli/src/api/catalog/getCatalogDependentFiles.ts 100.00% <100.00%> (ø)
packages/loader/src/webpackLoader.ts 90.90% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit ce660d7 into lingui:main May 17, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix-catalog-deps-watching branch May 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to resolve import messages.pot.po on v4.1.1
2 participants