Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extractor): support jsx in js files #1678

Merged
merged 1 commit into from
May 29, 2023

Conversation

timofei-iatsenko
Copy link
Collaborator

Description

It seems it's quite common to have JSX in *.js files (not *.jsx)
#1638 (comment)

@vercel
Copy link

vercel bot commented May 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 1:06pm

@github-actions
Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.44 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.59 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (894c877) 75.72% compared to head (fc33c97) 75.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1678   +/-   ##
=======================================
  Coverage   75.72%   75.72%           
=======================================
  Files          79       79           
  Lines        2039     2039           
  Branches      524      524           
=======================================
  Hits         1544     1544           
  Misses        379      379           
  Partials      116      116           
Impacted Files Coverage Δ
packages/cli/src/api/extractors/babel.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrii-bodnar andrii-bodnar merged commit e335458 into lingui:main May 29, 2023
@timofei-iatsenko timofei-iatsenko deleted the fix/support-jsx-in-js branch May 29, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants