feat(message-utils): make generateMessageId to be working in browser #1776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is some demand to compile catalogs and messages on the fly. The
generateMessageId
function used nodejs api before, and it makes it not possible to use in the browser. There is a native WebCrypro api which supported in both browser and nodejs, but unfortunately it's async only and could not be used in babel macros transformation which is synchronous.I've used a custom js sha256 implementation, which is according to theirs benchmark fast as a native implementation.
Also i did not like that tests for
compileMessage
Function is stored somewhere else, so i extracted them fromapi
package.Types of changes
Fixes # (issue)
Checklist