Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: double render due to wrong assertion #1817

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

aseerkt
Copy link
Contributor

@aseerkt aseerkt commented Dec 14, 2023

Description

Updated the assertion in useLinguiInit function to avoid double render in Next.js SWC example as per the suggestion given in #1814

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes #1814

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 8:48am

Copy link

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 2.81 KB (0%)
./packages/detect-locale/dist/index.mjs 723 B (0%)
./packages/react/dist/index.mjs 1.67 KB (0%)
./packages/remote-loader/dist/index.mjs 7.26 KB (0%)

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0def041) 76.38% compared to head (51184f5) 76.38%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1817   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files          81       81           
  Lines        2071     2071           
  Branches      529      529           
=======================================
  Hits         1582     1582           
  Misses        377      377           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aseerkt thank you!

@andrii-bodnar andrii-bodnar merged commit 8830f2e into lingui:main Dec 14, 2023
15 checks passed
@bravo-kernel
Copy link
Contributor

bravo-kernel commented Dec 31, 2023

Sweet, this solved a hard-to-find hydration error for me. Thanks a million 💗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double Render caused by wrong assertion
4 participants