fix(message-utils): correctly handle multi-digit complex argument cases

[Bertg]

Description

Current version of lingui will not handle following pluralisation correctly: {count, plural, one {One} other {#} =13 {thirteen}}. This PR fixes that.

I also added some tests, but maybe some dedicated test should be made, I'm not sure what the maintainer expect here.

Did not report the issue separately, as I already had the fix.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Examples update

Checklist

• I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
js-lingui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 15, 2024 9:07pm

[github-actions]

size-limit report 📦

Path	Size
./packages/core/dist/index.mjs	2.87 KB (0%)
./packages/detect-locale/dist/index.mjs	723 B (0%)
./packages/react/dist/index.mjs	1.67 KB (0%)
./packages/remote-loader/dist/index.mjs	7.26 KB (0%)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (d6b9698) to head (8f41475).
Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1937      +/-   ##
==========================================
- Coverage   76.65%   76.04%   -0.61%     
==========================================
  Files          81       85       +4     
  Lines        2090     2112      +22     
  Branches      533      541       +8     
==========================================
+ Hits         1602     1606       +4     
- Misses        375      393      +18     
  Partials      113      113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Bertg]

I also want to add an other suggestion here. Added it to the PR as from my POV it's a win.

I noticed that the cause of this bug was a wrong regex, and regexes are hard. We could replace that regex with this operation instead: item.key[0] === '=' ? item.key.slice(1) : item.key. I think this has several advantages:

• Not a regex! so easier to understand
• More intention revealing (now it is clear that this also handles cases not starting with a =
• A lot faster, like a lot... JSBench tells me the regex method is 92.48 % slower (based on micro test cases)

So if desired, I can add that optimisation to this PR as well, or add it as a separate PR.

[timofei-iatsenko]

Nice job. Thanks