-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (lingui/core) i18n error if id is undefined #1938
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Thanks for contribution. Could you add a test, otherwise it might be broken again in the future. |
you have issues in the pipeline |
Fixed it @thekip |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1938 +/- ##
==========================================
- Coverage 76.65% 76.07% -0.58%
==========================================
Files 81 85 +4
Lines 2090 2115 +25
Branches 533 543 +10
==========================================
+ Hits 1602 1609 +7
- Misses 375 393 +18
Partials 113 113 ☔ View full report in Codecov by Sentry. |
Description
Lingui Core - i18n._(id) throws error if id param passed as undefined
Types of changes
Fixes #1926
Checklist