fix: include type cast on ts compilation #1962
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In typescript projects which are using ts-reset and
compileNamespace: "ts"
, the compiled output is invalid because the type ofJSON.parse
is changed tounknown
from the normalany
, meaning that you cannot just use a type annotation and must use an explicit cast. There doesn't seem to be any simple configuration that could fix this issue, so this PR with an explicit type cast seems to be a logical answer.It doesn't affect anyone who is not using
ts-reset
, and expands compatibility for those who are.Types of changes
Checklist