Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update https://github.com/linkeddata/rdflib.js/blob/main/Documentation/update-manager.md #627

Closed
bourgeoa opened this issue Nov 26, 2023 · 4 comments · Fixed by #628
Assignees

Comments

@bourgeoa
Copy link
Contributor

@damooo @angelo-v
Can you update https://github.com/linkeddata/rdflib.js/blob/main/Documentation/update-manager.md following :

Does this imply that NSS could be able to use Accept-patch header nodeSolidServer/node-solid-server#1683 ?

@angelo-v
Copy link
Contributor

angelo-v commented Nov 26, 2023

Accept-patch header is already supported by rdflib for a while, but only with sparql update. Now it should work with n3 patch as well. I do not think that rdflib needs the ms-author-via header anymore

@bourgeoa
Copy link
Contributor Author

I don't think we can delete it for backward compatibility.

@angelo-v
Copy link
Contributor

I do not mean to remove it from rdflib, I am just saying that rdflib would be fine if NSS removed it

@damooo
Copy link
Contributor

damooo commented Nov 27, 2023

@damooo @angelo-v Can you update https://github.com/linkeddata/rdflib.js/blob/main/Documentation/update-manager.md following :

Created a PR #628

Does this imply that NSS could be able to use Accept-patch header nodeSolidServer/node-solid-server#1683 ?

Yes, if NSS sends accept-patch header with "text/n3" being one of supported mimes, rdflib should send a patch request with content-type text/n3, with body encoding a solid-insert-delete-patch. rdflib hounoured sparql-update for accept-patch since much before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants