Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build issues: :dao-impl:ebean-dao:test failing in time zones ahead of UTC. #243

Open
matthiasdg opened this issue Mar 2, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@matthiasdg
Copy link

Describe the bug A clear and concise description of what the bug is.

docs/developers.md says ./gradlew build should work, it no longer does out of the box. Before we were on ea281ea, had no problems then.
With current master (ff9a36b) I noticed I had to:

  • install libncurses5 (found this in .github/workflows/build-and-test.yml), maybe this can just be updated in the docs?
  • run TZ=UTC ./gradlew build to make :dao-impl:ebean-dao:test pass; otherwise I got stuff like
12:01:29.310 [DEBUG] [TestEventLogger] Gradle suite > Gradle test > com.linkedin.metadata.dao.localrelationship.EbeanLocalRelationshipWriterDAOTest.testAddRelationshipWithRemoveAllEdgesToDestination FAILED
12:01:29.311 [DEBUG] [TestEventLogger]     javax.persistence.PersistenceException: Data truncation: Incorrect datetime value: '1970-01-01 00:00:01' for column 'lastmodifiedon' at row 1

Think this is 1970/01/01 in my timezone (=GMT+1) hence before 1970 in UTC. Thought the latest commits could maybe have fixed it since they mentioned lastmodifiedon, but apparently the issue is still there (tested with a8fb6c9 and ff9a36b).

Expected behavior

Tests should work regardless of timezone

Desktop (please complete the following information):

Ubuntu 22.04

@matthiasdg matthiasdg added the bug Something isn't working label Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant