Comparison helpers should still execute when their key parameter is set ... #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
L(great)TM |
…et but resolves to undefined.
Previously, if a helper's key parameter was set, but the Dust variable to which it pointed did not exist, the helper would immediately abort. However, this breaks cases especially for {@ne} in which it would be completely valid if the key did not exist.
The helper will still fail to execute if a key parameter is not passed. However, if the parameter resolves to an undefined variable, it will now execute.
This is a non-backwards-compatible change. Closes LinkedInAttic#59.
sethkinast
force-pushed
the
eq-key-undef
branch
from
e22984a
to
b27c30a
Compare
|
Added an extra test for key and value both being undefined as per @kate2753 's comment |
prashn64
added a commit
that referenced
this pull request
Nov 20, 2014
Comparison helpers should still execute when their key parameter is set, but it resolves to undefined.
This was referenced Nov 18, 2019
This was referenced Nov 25, 2019
This was referenced Mar 13, 2020
This was referenced Jun 14, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...but resolves to undefined.
Previously, if a helper's key parameter was set, but the Dust variable to which it pointed did not exist, the helper would immediately abort. However, this breaks cases especially for {@ne} in which it would be completely valid if the key did not exist.
The helper will still fail to execute if a key parameter is not passed. However, if the parameter resolves to an undefined variable, it will now execute.
This is a non-backwards-compatible change. Closes #59.