This repository has been archived by the owner on Feb 17, 2021. It is now read-only.
Add right-to-left support to hopscotch #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 10, 2014 18:16
|
Looks good to me. Thanks for the updates! |
timlindvall
added a commit
that referenced
this pull request
Dec 2, 2014
Add right-to-left support to hopscotch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a configuration option to tours and individual callouts to "flip" the positioning of callouts . Callouts positioned on the top and bottom are shifted to their right-to-left position equivalent, and anything oriented "left" is switched to "right" and vice-versa. xOffset is respected. Instantiators must simply set the 'isRtl" flag to true when they are expecting to view the callout in a RTL language context.
Two util functions were created to handle the placement/orientation legacy handling, and the right-to-left switch. Additionally, the render and setPosition methods were updated to support the parameter.